Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Response to Reviewers #799

Merged
merged 16 commits into from
Jan 19, 2018
Merged

Draft Response to Reviewers #799

merged 16 commits into from
Jan 19, 2018

Conversation

cgreene
Copy link
Member

@cgreene cgreene commented Jan 17, 2018

Initial steps in this area. Currently WIP. @agitter feel free to pick up if you get time.

@cgreene cgreene requested a review from agitter January 17, 2018 16:58
@agitter agitter added this to the journal-revisions milestone Jan 17, 2018
Copy link
Contributor

@agapow agapow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can't see any issues

@cgreene
Copy link
Member Author

cgreene commented Jan 18, 2018

Ok - @agitter : this is off to you! Please note that I left two elements of the table for you to fill in. :)

@agitter
Copy link
Collaborator

agitter commented Jan 18, 2018

@cgreene I made a few more changes and think this is just about ready. Let's proofread one more time and merge it (and submit!).

Copy link
Member Author

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not allowed to approve or request changes on my own PR. This looks good to me. Just going to make that one change.

| Adversarial training | A process by which artificial training examples are maliciously designed to fool a NN and then input as training examples to make the resulting NN robust (no relation to GANs) |
| Data augmentation | A process by which transformations that do not affect relevant properties of the input data (e.g., arbitrary rotations of histopathology images) are applied to training examples to increase the size of the training set. |
Table @tbl:glossary also provides select example applications, though in practice each neural network architecture has been broadly applied across multiple types of biomedical data.
A recent book from Goodfellow et al. covers neural network architectures in detail [@url:http://www.deeplearningbook.org/], and LeCun et al. provides a more general introduction [@doi:10.1038/nature14539].
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide instead of provides? I think it's based on the many authors as opposed to the single entity paper.

@cgreene
Copy link
Member Author

cgreene commented Jan 19, 2018

Ok - with my change this is 👍 ! I think we are ready to go. Let me know & send over the marked document. I can submit tomorrow morning. 😀

@agitter agitter changed the title WIP: Draft Response to Reviewers Draft Response to Reviewers Jan 19, 2018
@agitter agitter merged commit 6bbf4c7 into greenelab:master Jan 19, 2018
This was referenced Jan 19, 2018
This was referenced Jan 19, 2018
dhimmel pushed a commit that referenced this pull request Jan 19, 2018
This build is based on
6bbf4c7.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/deep-review/builds/330649898
https://travis-ci.org/greenelab/deep-review/jobs/330649899

[ci skip]

The full commit message that triggered this build is copied below:

Draft Response to Reviewers (#799)

Draft Response to Reviewers
dhimmel pushed a commit that referenced this pull request Jan 19, 2018
This build is based on
6bbf4c7.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/deep-review/builds/330649898
https://travis-ci.org/greenelab/deep-review/jobs/330649899

[ci skip]

The full commit message that triggered this build is copied below:

Draft Response to Reviewers (#799)

Draft Response to Reviewers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants